On 05/08/2021 21.34, Eduardo Habkost wrote:
We have a SCLPEventsBus struct defined, but the struct is not used at the TypeInfo definition. This works today but will break silently if anybody adds a new field to SCLPEventsBus.Set instance_size properly to avoid problems in the future. Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> --- Cc: Cornelia Huck <coh...@redhat.com> Cc: Thomas Huth <th...@redhat.com> Cc: Halil Pasic <pa...@linux.ibm.com> Cc: Christian Borntraeger <borntrae...@de.ibm.com> Cc: Richard Henderson <richard.hender...@linaro.org> Cc: David Hildenbrand <da...@redhat.com> Cc: qemu-s3...@nongnu.org Cc: qemu-devel@nongnu.org --- hw/s390x/event-facility.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/s390x/event-facility.c b/hw/s390x/event-facility.c index ed92ce510d9..0a65e16cdd9 100644 --- a/hw/s390x/event-facility.c +++ b/hw/s390x/event-facility.c @@ -332,6 +332,7 @@ static void write_event_mask(SCLPEventFacility *ef, SCCB *sccb) static const TypeInfo sclp_events_bus_info = { .name = TYPE_SCLP_EVENTS_BUS, .parent = TYPE_BUS, + .instance_size = sizeof(SCLPEventsBus), };static void command_handler(SCLPEventFacility *ef, SCCB *sccb, uint64_t code)
Reviewed-by: Thomas Huth <th...@redhat.com>
