> On Fri, Aug 6, 2021 at 10:39 AM Bin Meng <bmeng...@gmail.com> wrote: > > > > On Fri, Aug 6, 2021 at 1:57 AM Ruinland Chuan-Tzu Tsai > > <ruinl...@andestech.com> wrote: > > > > > > From: Ruinland ChuanTzu Tsai <ruinl...@andestech.com> > > > > > > Adding option `riscv_custom` to configure script, meson.build and > > > meson_options.txt so as to toggle custom CSR and will-be-upstreamed custom > > > instructions handling logic. > > > > > > Signed-off-by: Dylan Jhong <dy...@andestech.com> > > > --- > > > configure | 6 ++++++ > > > meson.build | 2 ++ > > > meson_options.txt | 2 ++ > > > 3 files changed, 10 insertions(+) > > > > > > > This sounds like unnecessary to bring such a config option to the meson > > level. > > > > I believe a Kconfig option should just be fine. > > +Alistair
I don’t see why this is even a config option. If you request a vendor’s CPU you should get any custom CSRs defined for that vendor’s CPU. If you don’t you don’t. This should be purely a run-time thing, no? Jess
