On Tue, Aug 17, 2021 at 01:37:15PM +0100, Peter Maydell wrote: > On Tue, 17 Aug 2021 at 13:22, Andrew Jones <drjo...@redhat.com> wrote: > > > > On Tue, Aug 17, 2021 at 01:06:19PM +0100, Peter Maydell wrote: > > > On Tue, 17 Aug 2021 at 13:02, Andrew Jones <drjo...@redhat.com> wrote: > > > > > > > > On Mon, Aug 16, 2021 at 11:37:21PM +0200, Paolo Bonzini wrote: > > > > > How do we know that no one has ever used such configuration? The > > > > > conversion > > > > > was meant to be bug-compatible. > > > > > > > > We don't. But we do know that a zero input value was never documented > > > > prior to 1e63fe68580, which has not yet been released. Can we claim > > > > that an undocumented input value has undefined behavior, giving us > > > > freedom to modify that behavior until it is documented? > > > > > > Dunno; I definitely don't want a behaviour-change patch at this > > > point in the release-cycle, though... > > > > > > > Can we replace this patch with the following one for now? And then > > discuss this further before committing to supporting a zero input? > > If you can agree on that and send out a patch and get it reviewed > within the next three hours or so...
I posted the patch. Agreement/disagreement can come in the form of ack/nack. Hopefully in time... Thanks, drew