On 8/17/21 10:51 PM, Philippe Mathieu-Daudé wrote:
- void *ret = g2h(env_cpu(env), addr); + + ret = g2h(env_cpu(env), addr); set_helper_retaddr(retaddr); return ret;Can't we simply do: return g2h(env_cpu(env), addr); ?
I think the idea was to narrow the range of instructions in which helper_retaddr is set, because {set,clear}_helper_retaddr contain barriers. I didn't give it more thought this time around, just kept the ordering.
r~
