On 8/18/21 12:58 AM, Bin Meng wrote:
+ TCGv temp[4];Why is 4? Is it enough? Perhaps a comment here is needed here?
It's a round number that will cover three operands plus an extra for address computation. r~
- [PATCH v2 06/21] target/riscv: Remove gen_arith_di... Richard Henderson
- Re: [PATCH v2 06/21] target/riscv: Remove gen... Bin Meng
- Re: [PATCH v2 06/21] target/riscv: Remove gen... Alistair Francis
- [PATCH v2 09/21] target/riscv: Move gen_* helpers ... Richard Henderson
- Re: [PATCH v2 09/21] target/riscv: Move gen_*... Philippe Mathieu-Daudé
- Re: [PATCH v2 09/21] target/riscv: Move gen_*... Bin Meng
- [PATCH v2 04/21] target/riscv: Introduce DisasExte... Richard Henderson
- Re: [PATCH v2 04/21] target/riscv: Introduce ... Bin Meng
- Re: [PATCH v2 04/21] target/riscv: Introd... Richard Henderson
- Re: [PATCH v2 04/21] target/riscv: Introd... Richard Henderson
- Re: [PATCH v2 04/21] target/riscv: Introduce ... Alistair Francis
- [PATCH v2 03/21] target/riscv: Add DisasContext to... Richard Henderson
- Re: [PATCH v2 03/21] target/riscv: Add DisasC... Philippe Mathieu-Daudé
- Re: [PATCH v2 03/21] target/riscv: Add DisasC... Bin Meng
- Re: [PATCH v2 03/21] target/riscv: Add DisasC... Alistair Francis
- [PATCH v2 07/21] target/riscv: Use gen_arith for m... Richard Henderson
- Re: [PATCH v2 07/21] target/riscv: Use gen_ar... Bin Meng
- Re: [PATCH v2 07/21] target/riscv: Use gen_ar... Alistair Francis
- [PATCH v2 05/21] target/riscv: Add DisasExtend to ... Richard Henderson
