On 8/19/21 4:21 PM, Peter Maydell wrote: > On Thu, 19 Aug 2021 at 15:15, Philippe Mathieu-Daudé <phi...@redhat.com> > wrote: >> >> Fixes: 35593573b25 ("hw/dma: Implement a Xilinx CSU DMA model") >> Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com> >> --- >> hw/dma/xlnx_csu_dma.c | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/hw/dma/xlnx_csu_dma.c b/hw/dma/xlnx_csu_dma.c >> index 797b4fed8f5..0c1c19cab5a 100644 >> --- a/hw/dma/xlnx_csu_dma.c >> +++ b/hw/dma/xlnx_csu_dma.c >> @@ -660,6 +660,13 @@ static void xlnx_csu_dma_realize(DeviceState *dev, >> Error **errp) >> s->r_size_last_word = 0; >> } > > This is a sysbus device -- when can it ever get unrealized ?
Alright. Then we should add an assertion if a SysBusDevice has a non-NULL unrealize() handler.