On Thu, Oct 20, 2011 at 10:55:38AM +0200, Paolo Bonzini wrote: > On 10/20/2011 10:03 AM, Stuart Brady wrote: > >Convert calls to g_malloc() and g_malloc0() to g_new() and g_new0() > >respectively, in cases where the return value is casted to the same > >type as specified using sizeof() in the parameter to g_malloc() and > >assigned to a variable of that type. > > This is likely to cause conflicts all over the place, and now is a > very bad time to do so :( because people are trying to get their > patches in during the soft feature freeze. I don't oppose the > change, just the timing.
That makes sense. Perhaps I should just submit a patch for the allocation of GuestFileRead (which should be GuestFileSeek) in that case -- although since that's benign, I could just wait a little while longer. Cheers, -- Stuart