From: Matheus K. Ferst <matheus.fe...@eldorado.org.br> > > On 8/31/21 9:39 AM, Luis Pires wrote: > >> +DEF_HELPER_3(DCFFIXQQ, void, env, fprp, avr) > > > > Shouldn't be upcase. None of the others are. > > > > The reason for this change is on patch 13 and onwards. Matching the case of > the > instruction name in the trans_<INSN> method and the helper makes it easier to > create macros, e.g. TRANS_DFP_BF_A_DCM on patch 13. The idea was to > change the helpers as we moved instructions to decodetree. > > Alternatively, the macro could receive the instruction name and the > gen_helper_<INSN>, or we could drop this kind of macro usage in favor of > something else. The former is a bit repetitive, while the latter would require > more changes in the current code structure.
And our intention is also to send a standalone patch later on, changing to uppercase the other new (decodetree) helpers whose names are directly related to instruction names, making them consistent. -- Luis Pires Instituto de Pesquisas ELDORADO Aviso Legal - Disclaimer <https://www.eldorado.org.br/disclaimer.html>