On Sat, Sep 11, 2021 at 8:37 PM Bin Meng <bmeng...@gmail.com> wrote: > > On Fri, Sep 10, 2021 at 1:56 PM <frank.ch...@sifive.com> wrote: > > > > From: Frank Chang <frank.ch...@sifive.com> > > > > Setting Control.claim clears all of the chanel's Next registers. > > This is effective only when Control.claim is set from 0 to 1. > > > > Signed-off-by: Frank Chang <frank.ch...@sifive.com> > > Tested-by: Max Hsu <max....@sifive.com> > > --- > > hw/dma/sifive_pdma.c | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > > > diff --git a/hw/dma/sifive_pdma.c b/hw/dma/sifive_pdma.c > > index 9b2ac2017d9..e723db9d700 100644 > > --- a/hw/dma/sifive_pdma.c > > +++ b/hw/dma/sifive_pdma.c > > @@ -54,6 +54,9 @@ > > #define DMA_EXEC_DST 0x110 > > #define DMA_EXEC_SRC 0x118 > > > > +#define CONFIG_WRSZ_DEFAULT 6 > > +#define CONFIG_RDSZ_DEFAULT 6 > > The FU540 manual says the next config reset value is 0, not 6. >
>From patch#2 's log on Unmatched, I see where the number 6 is coming. I also validated on Unleashed and observed the same. So there is a documentation error. Please add a comment to explain that. Otherwise, Reviewed-by: Bin Meng <bmeng...@gmail.com>
