On 9/14/21 4:20 PM, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé <berra...@redhat.com>
> ---
> target/mips/cpu.c | 85 +++++++++++++++++++++++++----------------------
> 1 file changed, 45 insertions(+), 40 deletions(-)
>
> diff --git a/target/mips/cpu.c b/target/mips/cpu.c
> index d426918291..9ced90d810 100644
> --- a/target/mips/cpu.c
> +++ b/target/mips/cpu.c
> @@ -42,76 +42,81 @@ const char regnames[32][3] = {
> "t8", "t9", "k0", "k1", "gp", "sp", "s8", "ra",
> };
>
> -static void fpu_dump_fpr(fpr_t *fpr, FILE *f, bool is_fpu64)
> +static void fpu_dump_fpr(fpr_t *fpr, GString *buf, bool is_fpu64)
> {
> if (is_fpu64) {
> - qemu_fprintf(f, "w:%08x d:%016" PRIx64 " fd:%13g fs:%13g psu:
> %13g\n",
> - fpr->w[FP_ENDIAN_IDX], fpr->d,
> - (double)fpr->fd,
> - (double)fpr->fs[FP_ENDIAN_IDX],
> - (double)fpr->fs[!FP_ENDIAN_IDX]);
> + g_string_append_printf(buf, "w:%08x d:%016" PRIx64
> + " fd:%13g fs:%13g psu: %13g\n",
IIUC QEMU coding style, the 2nd part of the format should be
aligned with the first part. (multiple occurrences in this series).
Otherwise:
Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>
