On 9/15/21 9:18 AM, Philippe Mathieu-Daudé wrote: > On 9/14/21 4:20 PM, Daniel P. Berrangé wrote: >> Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> >> --- >> target/microblaze/cpu.c | 2 +- >> target/microblaze/cpu.h | 2 +- >> target/microblaze/translate.c | 45 ++++++++++++++++++----------------- >> 3 files changed, 25 insertions(+), 24 deletions(-) > >> for (i = 0; i < 32; i++) { >> - qemu_fprintf(f, "r%2.2d=%08x%c", >> - i, env->regs[i], i % 4 == 3 ? '\n' : ' '); >> + g_string_append_printf(buf, "r%2.2d=%08x%c", >> + i, env->regs[i], i % 4 == 3 ? '\n' : ' '); >> } >> - qemu_fprintf(f, "\n"); >> + g_string_append_printf(buf, "\n"); > > g_string_append_c(), otherwise:
Actually we don't need an extra newline. > Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> > >> } >> >> void mb_tcg_init(void) >> >