On Thu, Sep 16, 2021 at 3:29 PM John Snow <js...@redhat.com> wrote: > > A few new annoyances. Of note is the new warning for an unspecified > encoding when opening a text file, which actually does indicate a > potentially real problem; see > https://www.python.org/dev/peps/pep-0597/#motivation > > Use LC_CTYPE to determine an encoding to use for interpreting QEMU's > terminal output. Note that Python states: "language code and encoding > may be None if their values cannot be determined" -- use a platform > default as a backup. > > Notes: Passing encoding=None will generate a suppressed warning on > Python 3.10+ that 'None' should not be passed as the encoding > argument. This behavior may be deprecated in the future and the default > switched to be a ubiquitous UTF-8. Opting in to the locale default will > be done by passing the encoding 'locale', but that isn't available in > 3.6 through 3.9. Presumably this warning will be unsuppressed some time > prior to the actual switch and we can re-investigate these issues at > that time if necessary. > > Signed-off-by: John Snow <js...@redhat.com> > --- > python/qemu/machine/machine.py | 7 ++++++- > python/setup.cfg | 1 + > 2 files changed, 7 insertions(+), 1 deletion(-) >
Reviewed-by: Willian Rampazzo <willi...@redhat.com>
