Hi Richard, On 9/23/21 00:51, Richard Henderson wrote:
On 9/21/21 1:19 PM, WANG Xuerui wrote:+ case 0b00011111110: /* stle.w */ + case 0b00011111111: /* stle.d */ + is_write = 1; + break; + default: + /* test for am* instruction range */ + if (0b00011000000 <= sel && sel <= 0b00011100011) { + is_write = 1; + }Probably better to fold the range check into the switch with case 0b00011000000 ... 0b00011100011: /* am* insn range */
I just googled this particular syntax; it looks like a GCC-only extension, but is already used in a few places inside QEMU. So I think I'll take this advice and just make the range another switch arm.
