On Tue, Sep 28, 2021 at 11:57:43AM +0800, Yanan Wang wrote: > To pave the way for the functional improvement in later patches, > make some refactor/cleanup for the smp parsers, including using > local maxcpus instead of ms->smp.max_cpus in the calculation, > defaulting dies to 0 initially like other members, cleanup the > sanity check for dies. > > We actually also fix a hidden defect by avoiding directly using > the provided *zero value* in the calculation, which could cause > a segment fault (e.g. using dies=0 in the calculation). > > Signed-off-by: Yanan Wang <wangyana...@huawei.com> > Reviewed-by: Andrew Jones <drjo...@redhat.com> > --- > hw/core/machine.c | 18 ++++++++++-------- > hw/i386/pc.c | 23 ++++++++++++++--------- > 2 files changed, 24 insertions(+), 17 deletions(-)
Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
