Hello, Gerd! On Tue, Sep 28, 2021 at 07:06:28AM +0200, Gerd Hoffmann wrote: > On Mon, Sep 27, 2021 at 11:11:58AM -0300, Jose R. Ziviani wrote: > > This patchset introduces the modinfo_need and changes > > modinfo-generate.py/meson.build to generate/link one modinfo per target. > > > > modinfo-generate.py will know, thanks to modinfo_need, which modules are > > currently enabled for a given target before adding it in the array of > > modules. It will give a hint about why some modules failed, so > > developers can have a clue about it: > > The approach looks good to me.
Awesome, I'll apply your review and send a new version. Thank you! > > > /* hw-display-qxl.modinfo */ > > /* module QXL is missing. */ > > You are using kconfig symbols here, so the comment should say so ;) > > Renaming modinfo_need to modinfo_kconfig will probably also help > to make that clear. > > > /* hw-display-virtio-gpu.modinfo */ > > .name = "hw-display-virtio-gpu", > > .objs = ((const char*[]){ "virtio-gpu-base", "virtio-gpu-device", > > "vhost-user-gpu", NULL }), > > Hmm? Leftover from an older version of the series? > > > - accelerators can be filtered as well (this only covers the device > > part), then the field QemuModinfo.arch can be removed. > > It's target-specific modules. Although accelerators are the only > in-tree users right this is not limited to accelerators. > > take care, > Gerd >
signature.asc
Description: Digital signature