This patchset introduces the modinfo_kconfig aiming for a fine-tune
control of module loading by simply checking Kconfig options during the
compile time, then generates one modinfo-<target>-softmmu.c per target.
The main reason of this change is to fix problems like:
$ ./qemu-system-s390x -nodefaults -display none -accel tcg -M none -device help
| head
Failed to open module: /.../hw-display-qxl.so: undefined symbol: vga_ioport_read
Failed to open module: /.../hw-display-virtio-vga.so: undefined symbol:
vmstate_vga_common
Failed to open module: /.../hw-display-virtio-vga.so: undefined symbol:
vmstate_vga_common
Failed to open module: /.../hw-display-virtio-vga-gl.so: undefined symbol:
have_vga
Failed to open module: /.../hw-usb-smartcard.so: undefined symbol:
ccid_card_ccid_attach
Failed to open module: /.../hw-usb-redirect.so: undefined symbol:
vmstate_usb_device
Failed to open module: /.../hw-usb-host.so: undefined symbol: vmstate_usb_device
With this patch, I run this small script successfuly:
#!/bin/bash
pushd ~/suse/virtualization/qemu/build
for qemu in qemu-system-*
do
[[ -f "$qemu" ]] || continue
res=$(./$qemu -nodefaults -display none -accel tcg -M none -device help
2>&1 | grep "Failed to" > /dev/null; echo $?)
[[ $res -eq 0 ]] && echo "Error: $qemu"
done
popd
Also run 'make check' and 'check-acceptance' without any failures.
v2 -> v3:
- Renamed module_needs to module_kconfig [Gerd]
- Reworded the commit message a bit to improve a better understanding [myself]
v1 -> v2:
- Changed the approach to this problem after suggestions made by Paolo and
Gerd.
Thank you!
Jose R. Ziviani (2):
modules: introduces module_kconfig directive
modules: generates per-target modinfo
hw/display/qxl.c | 1 +
hw/display/vhost-user-gpu-pci.c | 1 +
hw/display/vhost-user-gpu.c | 1 +
hw/display/vhost-user-vga.c | 1 +
hw/display/virtio-gpu-base.c | 1 +
hw/display/virtio-gpu-gl.c | 1 +
hw/display/virtio-gpu-pci-gl.c | 1 +
hw/display/virtio-gpu-pci.c | 1 +
hw/display/virtio-gpu.c | 1 +
hw/display/virtio-vga-gl.c | 1 +
hw/display/virtio-vga.c | 1 +
hw/s390x/virtio-ccw-gpu.c | 1 +
hw/usb/ccid-card-emulated.c | 1 +
hw/usb/ccid-card-passthru.c | 1 +
hw/usb/host-libusb.c | 1 +
hw/usb/redirect.c | 1 +
include/qemu/module.h | 10 ++++++++
meson.build | 25 +++++++++++++-------
scripts/modinfo-generate.py | 42 ++++++++++++++++++++-------------
19 files changed, 69 insertions(+), 24 deletions(-)
--
2.33.0
