On Fri, 1 Oct 2021 at 10:10, Daniel P. Berrangé <berra...@redhat.com> wrote: > > On Thu, Sep 30, 2021 at 09:10:12AM +0200, Thomas Huth wrote: > > On 27/08/2021 14.09, Thomas Huth wrote: > > > The dtc submodule is currently pointing to non-release commit. It's nicer > > > if submodules point to release versions instead and since dtc 1.6.1 is > > > available now, let's update to that version.
> Most of our supported platforms don't have version 1.6.1 available. > > As a general goal IMHO we should be seeking to eliminate bundling of > 3rd party modules that are commonly available in distros. We've > carried dtc for a hell of a long time, and if we keep updating our > submodule we'll keep relyin on new features, and never be able to > drop it because it will always be newer than what's in the distros. > > So personally I think we should never again update dtc and capstone > modules. If we want to take adbantage of new features, then do that > through conditional compilation, as we do for any of the other 3rd > party libraries consumed. I agree in general, but (per the commit message here) our dtc submodule is currently pointing at some random not-a-release commit in upstream dtc. We should at least move forward to whatever the next released dtc after that is, before we say "no more dtc updates". -- PMM
