On 02/10/21 14:52, Philippe Mathieu-Daudé wrote:
Hi,
While testing James & Dov patch:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg810571.html
I wasted some time trying to figure out how OVMF was supposed to
behave until realizing the binary I was using was built without SEV
support... Then wrote this series to help other developers to not
hit the same problem.
Since v2:
- Rebased on top of SGX
- Addressed review comments from Markus / David
- Included/rebased 'Measured Linux SEV guest' from Dov [1]
- Added orphean MAINTAINERS section
I have queued Dov's patches already, but apart from that the changes
from v3 to v4 should be minimal.
Thanks for this work!
Paolo
[1]
https://lore.kernel.org/qemu-devel/20210825073538.959525-1-dovmu...@linux.ibm.com/
Supersedes: <20210616204328.2611406-1-phi...@redhat.com>
Dov Murik (2):
sev/i386: Introduce sev_add_kernel_loader_hashes for measured linux
boot
x86/sev: generate SEV kernel loader hashes in x86_load_linux
Dr. David Alan Gilbert (1):
target/i386/sev: sev_get_attestation_report use g_autofree
Philippe Mathieu-Daudé (19):
qapi/misc-target: Wrap long 'SEV Attestation Report' long lines
qapi/misc-target: Group SEV QAPI definitions
target/i386/kvm: Introduce i386_softmmu_kvm Meson source set
target/i386/kvm: Restrict SEV stubs to x86 architecture
target/i386/monitor: Return QMP error when SEV is disabled in build
target/i386/cpu: Add missing 'qapi/error.h' header
target/i386/sev_i386.h: Remove unused headers
target/i386/sev: Remove sev_get_me_mask()
target/i386/sev: Mark unreachable code with g_assert_not_reached()
target/i386/sev: Restrict SEV to system emulation
target/i386/sev: Declare system-specific functions in 'sev_i386.h'
target/i386/sev: Remove stubs by using code elision
target/i386/sev: Move qmp_query_sev_attestation_report() to sev.c
target/i386/sev: Move qmp_sev_inject_launch_secret() to sev.c
target/i386/sev: Move qmp_query_sev_capabilities() to sev.c
target/i386/sev: Move qmp_query_sev_launch_measure() to sev.c
target/i386/sev: Move qmp_query_sev() & hmp_info_sev() to sev.c
monitor: Restrict 'info sev' to x86 targets
MAINTAINERS: Cover AMD SEV files
qapi/misc-target.json | 77 ++++----
include/monitor/hmp-target.h | 1 +
include/monitor/hmp.h | 1 -
include/sysemu/sev.h | 20 +-
target/i386/sev_i386.h | 32 +--
hw/i386/pc_sysfw.c | 2 +-
hw/i386/x86.c | 25 ++-
target/i386/cpu.c | 17 +-
{accel => target/i386}/kvm/sev-stub.c | 0
target/i386/monitor.c | 92 +--------
target/i386/sev-stub.c | 83 --------
target/i386/sev-sysemu-stub.c | 70 +++++++
target/i386/sev.c | 268 +++++++++++++++++++++++---
MAINTAINERS | 7 +
accel/kvm/meson.build | 1 -
target/i386/kvm/meson.build | 8 +-
target/i386/meson.build | 4 +-
17 files changed, 438 insertions(+), 270 deletions(-)
rename {accel => target/i386}/kvm/sev-stub.c (100%)
delete mode 100644 target/i386/sev-stub.c
create mode 100644 target/i386/sev-sysemu-stub.c