On 29/09/2021 13.41, Markus Armbruster wrote:
[...]
In my opinion, use of CONFIG_FOO in QAPI schemata is no worse than using
them in C type definitions.
In both cases, we have a choice: compile out stuff this build doesn't
need with compile-time conditionals, or leave it in unused.
In C, we sometimes have to compile out stuff, say when it depends on
headers we don't have.
In QAPI, we sometimes want to compile out stuff to make introspection
more useful. This can be a killer argument.
So what's your opinion on this patch here? Good to go? Needs a rework? Or
should I simply forget about it?
Thomas
