On Tue, Oct 12, 2021 at 7:20 AM Markus Armbruster <arm...@redhat.com> wrote: > > Eugenio Pérez <epere...@redhat.com> writes: > > > Shadow virtqueue notifications forwarding is disabled when vhost_dev > > stops, so code flow follows usual cleanup. > > > > Also, host notifiers must be disabled at SVQ start, and they will not > > start if SVQ has been enabled when device is stopped. This is trivial > > to address, but it is left out for simplicity at this moment. > > > > Signed-off-by: Eugenio Pérez <epere...@redhat.com> > > --- > > qapi/net.json | 2 +- > > hw/virtio/vhost-shadow-virtqueue.h | 8 ++ > > include/hw/virtio/vhost-vdpa.h | 4 + > > hw/virtio/vhost-shadow-virtqueue.c | 138 ++++++++++++++++++++++++++++- > > hw/virtio/vhost-vdpa.c | 116 +++++++++++++++++++++++- > > 5 files changed, 264 insertions(+), 4 deletions(-) > > > > diff --git a/qapi/net.json b/qapi/net.json > > index a2c30fd455..fe546b0e7c 100644 > > --- a/qapi/net.json > > +++ b/qapi/net.json > > @@ -88,7 +88,7 @@ > > # > > # @enable: true to use the alternate shadow VQ notifications > > # > > -# Returns: Always error, since SVQ is not implemented at the moment. > > +# Returns: Error if failure, or 'no error' for success. > > Delete the whole line, please. >
I will do it. Thanks! > > # > > # Since: 6.2 > > # > [...] >