Eugenio Perez Martin <epere...@redhat.com> writes: > On Tue, Oct 12, 2021 at 7:18 AM Markus Armbruster <arm...@redhat.com> wrote: >> >> Eugenio Pérez <epere...@redhat.com> writes: >> >> > Command to enable shadow virtqueue. >> > >> > Signed-off-by: Eugenio Pérez <epere...@redhat.com> >> > --- >> > qapi/net.json | 23 +++++++++++++++++++++++ >> > hw/virtio/vhost-vdpa.c | 8 ++++++++ >> > 2 files changed, 31 insertions(+) >> > >> > diff --git a/qapi/net.json b/qapi/net.json >> > index 7fab2e7cd8..a2c30fd455 100644 >> > --- a/qapi/net.json >> > +++ b/qapi/net.json >> > @@ -79,6 +79,29 @@ >> > { 'command': 'netdev_del', 'data': {'id': 'str'}, >> > 'allow-preconfig': true } >> > >> > +## >> > +# @x-vhost-enable-shadow-vq: >> > +# >> > +# Use vhost shadow virtqueue. >> > +# >> > +# @name: the device name of the VirtIO device >> >> Is this a qdev ID? A network client name? > > At this moment is the virtio device name, the one specified at the > call of "virtio_init". But this should change, maybe the qdev id or > something that can be provided by the command line fits better here.
To refer to a device backend, we commonly use a backend-specific ID. For network backends, that's NetClientState member name. To refer to a device frontend, we commonly use a qdev ID or a QOM path. [...]