On Wed, Oct 13, 2021 at 6:53 AM Hanna Reitz <hre...@redhat.com> wrote:
> On 04.10.21 23:04, John Snow wrote:
> > More separation of code and configuration.
> >
> > Signed-off-by: John Snow <js...@redhat.com>
> > ---
> > tests/qemu-iotests/297 | 14 +-------------
> > tests/qemu-iotests/mypy.ini | 12 ++++++++++++
> > 2 files changed, 13 insertions(+), 13 deletions(-)
> > create mode 100644 tests/qemu-iotests/mypy.ini
>
> Reviewed-by: Hanna Reitz <hre...@redhat.com>
>
> > diff --git a/tests/qemu-iotests/297 b/tests/qemu-iotests/297
> > index bc3a0ceb2aa..b8101e6024a 100755
> > --- a/tests/qemu-iotests/297
> > +++ b/tests/qemu-iotests/297
> > @@ -73,19 +73,7 @@ def run_linters():
> > sys.stdout.flush()
> >
> > env['MYPYPATH'] = env['PYTHONPATH']
> > - p = subprocess.run(('mypy',
> > - '--warn-unused-configs',
> > - '--disallow-subclassing-any',
> > - '--disallow-any-generics',
> > - '--disallow-incomplete-defs',
> > - '--disallow-untyped-decorators',
> > - '--no-implicit-optional',
> > - '--warn-redundant-casts',
> > - '--warn-unused-ignores',
> > - '--no-implicit-reexport',
> > - '--namespace-packages',
> > - '--scripts-are-modules',
> > - *files),
> > + p = subprocess.run(('mypy', *files),
> > env=env,
> > check=False,
> > stdout=subprocess.PIPE,
> > diff --git a/tests/qemu-iotests/mypy.ini b/tests/qemu-iotests/mypy.ini
> > new file mode 100644
> > index 00000000000..4c0339f5589
> > --- /dev/null
> > +++ b/tests/qemu-iotests/mypy.ini
> > @@ -0,0 +1,12 @@
> > +[mypy]
> > +disallow_any_generics = True
> > +disallow_incomplete_defs = True
> > +disallow_subclassing_any = True
> > +disallow_untyped_decorators = True
> > +implicit_reexport = False
>
> Out of curiosity: Any reason you chose to invert this one, but none of
> the rest? (i.e. no_implicit_optional = True -> implicit_optional =
> False; or disallow* = True -> allow* = False)
>
>
Anything written as '--no-xxx' I wrote as 'xxx = False', but
"implicit_optional = False" isn't a supported option, so that one kept the
"no" in it.
--js
