On 10/27/21 1:32 PM, Luis Fernando Fujita Pires wrote:
From: Richard Henderson <richard.hender...@linaro.org>

  static bool fold_add2(OptContext *ctx, TCGOp *op)  {
+    swap_commutative(op->args[0], &op->args[2], &op->args[4]);
+    swap_commutative(op->args[1], &op->args[3], &op->args[5]);

This was existing code, but I would've understood it easier if it had a comment noting 
that, even though it would be possible for this code to swap args[2] <-> args[4] and 
not args[3] <-> arg5 (and vice-versa), this would be okay for an add. :)

Certainly.  Added.


r~

Reply via email to