On 10/29/21 16:22, Damien Hedde wrote: > Now that we check sysbus device types during device creation, we > can remove the check in the machine init done notifier. > This was the only thing done by this notifier, so we remove the > whole sysbus_notifier structure of the MachineState. > > Note: This notifier was checking all /peripheral and /peripheral-anon > sysbus devices. Now we only check those added by -device cli option or > device_add qmp command when handling the command/option. So if there > are some devices added in one of these containers manually (eg in > machine C code), these will not be checked anymore. > This use case does not seem to appear apart from > hw/xen/xen-legacy-backend.c (it uses qdev_set_id() and in this case, > not for a sysbus device, so it's ok). > > Signed-off-by: Damien Hedde <damien.he...@greensocs.com> > Acked-by: Alistair Francis <alistair.fran...@wdc.com> > --- > > v3: clarify the commit title > --- > include/hw/boards.h | 1 - > hw/core/machine.c | 27 --------------------------- > 2 files changed, 28 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>
