I was trying to allow attaching a device using "-device xxx,bus=smbus[0]"
Maybe there's a better way to allow that?
I guess I can drop this one from the patch set.
On Mon, Nov 1, 2021 at 10:33 AM Peter Maydell <peter.mayd...@linaro.org>
wrote:
> On Thu, 21 Oct 2021 at 19:40, Hao Wu <wuhao...@google.com> wrote:
> >
> > The ID can be used to indicate SMBus modules when adding
> > dynamic devices to them.
> >
> > Signed-off-by: Hao Wu <wuhao...@google.com>
> > ---
> > hw/arm/npcm7xx.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/hw/arm/npcm7xx.c b/hw/arm/npcm7xx.c
> > index 2ab0080e0b..72953d65ef 100644
> > --- a/hw/arm/npcm7xx.c
> > +++ b/hw/arm/npcm7xx.c
> > @@ -421,6 +421,7 @@ static void npcm7xx_init(Object *obj)
> > for (i = 0; i < ARRAY_SIZE(s->smbus); i++) {
> > object_initialize_child(obj, "smbus[*]", &s->smbus[i],
> > TYPE_NPCM7XX_SMBUS);
> > + DEVICE(&s->smbus[i])->id = g_strdup_printf("smbus[%d]", i);
> > }
>
> This one looks weird to me -- I'm pretty sure we shouldn't be messing
> about with the DeviceState id string like that. It's supposed to be
> internal to the QOM/qdev code.
>
> -- PMM
>
