On Tue, Nov 02, 2021 at 09:51:35AM +0100, Philippe Mathieu-Daudé wrote: > On 10/26/21 17:11, Eduardo Habkost wrote: > > The i440fx and Q35 machine types are both hardcoded to use the > > legacy SMBIOS 2.1 (32-bit) entry point. This is a sensible > > conservative choice because SeaBIOS only supports SMBIOS 2.1 > > > > EDK2, however, can also support SMBIOS 3.0 (64-bit) entry points, > > and QEMU already uses this on the ARM virt machine type. > > > > This adds a property to allow the choice of SMBIOS entry point > > versions For example to opt in to 64-bit SMBIOS entry point: > > > > $QEMU -machine q35,smbios-entry-point-type=64 > > It would be nice to have a test for this... > > Otherwise, > Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>
Can we update seabios and the switch the default? Maybe just for q35? Or are there more considerations? > > Based on a patch submitted by Daniel Berrangé. > > > > Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> > > Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> > > --- > > This is patch was previously submitted at: > > https://lore.kernel.org/qemu-devel/20200908165438.1008942-6-berra...@redhat.com > > > > Changes from v2: > > * Rename "smbios-ep" to "smbios-entry-point-type" > > > > Changes from v1: > > * Include qapi-visit-smbios.h instead of qapi-visit-machine.h > > * Commit message fix: s/smbios_ep/smbios-ep/ > > --- > > include/hw/i386/pc.h | 4 ++++ > > hw/i386/pc.c | 26 ++++++++++++++++++++++++++ > > hw/i386/pc_piix.c | 2 +- > > hw/i386/pc_q35.c | 2 +- > > 4 files changed, 32 insertions(+), 2 deletions(-)
