On Mon, Nov 01, 2021 at 02:56:43PM +0000, Peter Maydell wrote: > On Tue, 19 Oct 2021 at 10:04, Kashyap Chamarthy <kcham...@redhat.com> wrote: > > > > My main motivation was to convert SubmitAPatch[1] based on a chat with > > Peter Maydell and Dan Berrangé on #qemu channel (on OFTC). But the page > > also links to a couple of other contribution-related pages, so I > > converted them too: > > > > - SubmitAPullRequest: https://wiki.qemu.org/Contribute/SubmitAPullRequest > > - KeySigningParty: https://wiki.qemu.org/KeySigningParty > > - SpellCheck: https://wiki.qemu.org/Contribute/SpellCheck > > - TrivialPatches: https://wiki.qemu.org/Contribute/TrivialPatches > > I'm not sure that SpellCheck in particular is sufficiently baked > to be in the actual docs. I'd rather just drop the reference to it > from SubmitAPatch.
Sure, will drop. > KeySigningParty I'm on the fence about. This is linked only from the SubmitAPullRequest page. If we're ambivalent about it, I'll just keep it in for reference. I'll also fix the index-updating part you caught in your other review. Thanks for the review. -- /kashyap
