On Tue, Nov 02, 2021 at 03:57:08PM +0100, Philippe Mathieu-Daudé wrote: > On 10/28/21 17:54, Daniel P. Berrangé wrote: > > This is a counterpart to the HMP "info irq" command. It is being > > added with an "x-" prefix because this QMP command is intended as an > > adhoc debugging tool and will thus not be modelled in QAPI as fully > > structured data, nor will it have long term guaranteed stability. > > The existing HMP command is rewritten to call the QMP command. > > > > This command is unable to use the pre-existing HumanReadableText, > > because if 'common.json' is included into 'machine-target.json' > > the static marshalling method for HumanReadableText will be reported > > as unused by the compiler on all architectures except s390x. > > > > Possible options were > > > > 1 Support 'if' conditionals on 'include' statements in QAPI > > 2 Add further commands to 'machine-target.json' that use > > HumanReadableText, such that it has at least one usage > > on all architecture targets. > > 3 Duplicate HumanReadableText as TargetHumanReadableText > > adding conditions > > > > This patch takes option (3) in the belief that we will eventually > > get to a point where option (2) happens, and TargetHumanReadableText > > can be removed again. > > Outdated description from v2, otherwise:
Opps, this one should actually never have had this footnote, as its command is in machine.json, not machine-target.json ! > Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com> > > > Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> > > --- > > hmp-commands-info.hx | 2 +- > > monitor/hmp-cmds.c | 38 -------------------------------------- > > monitor/qmp-cmds.c | 44 ++++++++++++++++++++++++++++++++++++++++++++ > > qapi/machine.json | 12 ++++++++++++ > > 4 files changed, 57 insertions(+), 39 deletions(-) > Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|