On Fri, Nov 12, 2021 at 09:32:31PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Add Den and Roman (his new address)
Thanks, I missed it on the list indeed. > 06.11.2021 16:41, Philippe Mathieu-Daudé wrote: > > This is the 4th time I send this patch. Is the VMBus infrastructure > > used / maintained? Should we deprecate & remove? I think it's fair to say it's not maintained. The whole hw/hyperv/vmbus.c was submitted as a part of the work by Jon to enable some obscure windows debugging feature which only worked in presence of VMBus. It was mostly taken from the respective branch of the (now effectively abandoned) downstream tree with an implementation of the core VMBus infrastructure and the devices using it; however, none of the actual VMBus devices ever made it into the mainline tree. > > > > $ ./scripts/get_maintainer.pl -f hw/hyperv/vmbus.c -f > > include/hw/hyperv/vmbus.h > > get_maintainer.pl: No maintainers found > > > > Philippe Mathieu-Daudé (1): > > hw/hyperv/vmbus: Remove unused vmbus_load/save_req() > > > > include/hw/hyperv/vmbus.h | 3 -- > > hw/hyperv/vmbus.c | 59 --------------------------------------- > > 2 files changed, 62 deletions(-) This seems to basically be the revert of 4dd8a7064b "vmbus: add infrastructure to save/load vmbus requests"; it was originally meant to be submitted with the code that would use it, vmbus scsi controller, but that never happened. It believe it's safe to remove without affecting Jon's work, but I'd rather check with him. Thanks, Roman.