> -----Original Message----- > From: Richard Henderson <richard.hender...@linaro.org> > Sent: Wednesday, November 17, 2021 1:18 AM > To: Philippe Mathieu-Daudé <f4...@amsat.org>; qemu-devel@nongnu.org > Cc: Laurent Vivier <laur...@vivier.eu>; Taylor Simpson > <tsimp...@quicinc.com> > Subject: Re: [PATCH] linux-user/hexagon: Use generic target_stat64 > structure > > On 11/16/21 10:09 PM, Philippe Mathieu-Daudé wrote: > > Linux Hexagon port doesn't define a specific 'struct stat' > > but uses the generic one (see Linux commit 6103ec56c65c [*] > > "asm-generic: add generic ABI headers" which predates the introduction > > of the Hexagon port). > > > > Remove the target specific target_stat (which in fact is the > > target_stat64 structure but uses incorrect target_long and ABI unsafe > > long long types) and use the generic target_stat64 instead. > > > > [*]https://github.com/torvalds/linux/commit/6103ec56c65c3#diff-5f59b07 > > b38273b7d6a74193bc81a8cd18928c688276eae20cb10c569de3253ee > > > > Signed-off-by: Philippe Mathieu-Daudé<f4...@amsat.org> > > --- > > linux-user/syscall_defs.h | 28 ++-------------------------- > > 1 file changed, 2 insertions(+), 26 deletions(-) > > Reviewed-by: Richard Henderson <richard.hender...@linaro.org>
Reviewed-by: Taylor Simpson <tsimp...@quicinc.com> Tested-by: Taylor Simpson <tsimp...@quicinc.com>