Re: [PATCH v1] hw/i386/amd_iommu: clean up broken event logging

[Valentin Sinitsyn]

On 18.11.2021 00:03, Roman Kagan wrote:

On Wed, Nov 17, 2021 at 11:13:27PM +0500, Valentin Sinitsyn wrote:

On 17.11.2021 19:46, Daniil Tatianin wrote:

-/*
- * AMDVi event structure
- *    0:15   -> DeviceID
- *    55:63  -> event type + miscellaneous info
- *    63:127 -> related address

Did you mean 64:127? Fields shouldn't overlap, and 65-bit address looks
suspicious.

These lines are being removed by this patch.  And yes, they were wrong
WRT the spec.

Oops I missed a minus. Sorry for that.

Valentin