On Tue, 14 Dec 2021 at 11:04, Francisco Iglesias <francisco.igles...@xilinx.com> wrote: > > Connect Versal's PMC SLCR (system-level control registers) model. > > Signed-off-by: Francisco Iglesias <francisco.igles...@xilinx.com> > --- > hw/arm/xlnx-versal.c | 71 > +++++++++++++++++++++++++++++++++++++++++++- > include/hw/arm/xlnx-versal.h | 5 ++++ > 2 files changed, 75 insertions(+), 1 deletion(-)
> +static void versal_unimp_sd_emmc_sel(void *opaque, int n, int level) > +{ > + qemu_log_mask(LOG_UNIMP, > + "Selecting between enabling SD mode or eMMC mode on " > + "controller %d is not yet unimplemented\n", n); > +} > + > +static void versal_unimp_qspi_ospi_mux_sel(void *opaque, int n, int level) > +{ > + qemu_log_mask(LOG_UNIMP, > + "Selecting between enabling the QSPI or OSPI linear > address " > + "region is not yet unimplemented\n"); > +} > + > +static void versal_unimp_irq_parity_imr(void *opaque, int n, int level) > +{ > + qemu_log_mask(LOG_UNIMP, > + "PMC SLCR parity interrupt behaviour " > + "is not yet unimplemented\n"); > +} These should all say "not yet implemented". Otherwise Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM