On Sat, 8 Jan 2022 at 06:33, Richard Henderson <richard.hender...@linaro.org> wrote: > > We will shortly allow the use of unaligned memory accesses, > and these require proper alignment. Use get_alignment_bits > to verify and remove USING_SOFTMMU. > > Signed-off-by: Richard Henderson <richard.hender...@linaro.org> > --- > tcg/arm/tcg-target.c.inc | 22 ++++++++-------------- > 1 file changed, 8 insertions(+), 14 deletions(-) > > diff --git a/tcg/arm/tcg-target.c.inc b/tcg/arm/tcg-target.c.inc > index ea8b90e6e2..8a20224dd1 100644 > --- a/tcg/arm/tcg-target.c.inc > +++ b/tcg/arm/tcg-target.c.inc > @@ -35,12 +35,6 @@ bool use_neon_instructions; > #endif > > /* ??? Ought to think about changing CONFIG_SOFTMMU to always defined. */ > -#ifdef CONFIG_SOFTMMU > -# define USING_SOFTMMU 1 > -#else > -# define USING_SOFTMMU 0 > -#endif
Removing this ifdef leaves the CONFIG_SOFTMMU ??? comment without anything it refers to. The perennial question of whether we should have a linux-user with softmmu isn't very arm-specific, so I would just delete the ??? comment too. Anyway Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM