On Thu, Jan 27, 2022 at 12:44 AM Richard Henderson <
richard.hender...@linaro.org> wrote:

> On 1/25/22 12:29, Warner Losh wrote:
> > Fill in queue signal implementation, as well as routines allocate and
> > delete elements of the signal queue.
> >
> > Signed-off-by: Stacey Son <s...@freebsd.org>
> > Signed-off-by: Kyle Evans <kev...@freebsd.org>
> > Signed-off-by: Warner Losh <i...@bsdimp.com>
> > ---
> >   bsd-user/qemu.h   |  1 +
> >   bsd-user/signal.c | 13 ++++++++++++-
> >   2 files changed, 13 insertions(+), 1 deletion(-)
>
> Reviewed-by: Richard Henderson <richard.hender...@linaro.org>
>
> > +    struct emulated_sigtable sync_signal;
> >       struct emulated_sigtable sigtab[TARGET_NSIG];
>
> I'll note that we don't need an array of these, since we block all signals
> while returning
> to the main cpu loop, so we can't receive a second async signal.
> Something to be fixed
> for both l-user and b-user later...
>

I'll add
+    /*
+     * TODO: Since we block all signals while returning to the main CPU
+     * loop, this needn't be an array
+     */
before the array to document this so it doesn't get lost...

Warner

Reply via email to