On Thu, Jan 27, 2022 at 10:50 AM Hanna Reitz <hre...@redhat.com> wrote: > > On 24.01.22 19:06, John Snow wrote: > > The synchronous QMP library would bind to the server address during > > __init__(). The new library delays this to the accept() call, because > > binding occurs inside of the call to start_[unix_]server(), which is an > > async method -- so it cannot happen during __init__ anymore. > > > > Python 3.7+ adds the ability to create the server (and thus the bind() > > call) and begin the active listening in separate steps, but we don't > > have that functionality in 3.6, our current minimum. > > > > Therefore ... Add a temporary workaround that allows the synchronous > > version of the client to bind the socket in advance, guaranteeing that > > there will be a UNIX socket in the filesystem ready for the QEMU client > > to connect to without a race condition. > > > > (Yes, it's a bit ugly. Fixing it more nicely will have to wait until our > > minimum Python version is 3.7+.) > > I mean. Looks good to me? Not quite enough for an R-b, I’d say, and > you don’t really need an A-b from me on this, but looks good to me! O:) >
Works for me, thanks!
