"Dr. David Alan Gilbert" <dgilb...@redhat.com> wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> "Dr. David Alan Gilbert" <dgilb...@redhat.com> wrote: >> > * Juan Quintela (quint...@redhat.com) wrote: >> >> "Dr. David Alan Gilbert (git)" <dgilb...@redhat.com> wrote: >> >> > From: "Dr. David Alan Gilbert" <dgilb...@redhat.com> >> >> > >> >> > Perform a check on vmsd structures during test runs in the hope >> >> > of catching any missing terminators and other simple screwups. >> >> > >> >> > Signed-off-by: Dr. David Alan Gilbert <dgilb...@redhat.com> >> >> >> >> Reviewed-by: Juan Quintela <quint...@redhat.com> >> >> >> >> queued. >> > >> > Careful; I think that'll break with slirp until libslirp gets updated >> > first. >> >> As expected, it broke it. >> >> I resend the PULL request wihtout that two patches. >> >> Once that we are here, how it is that make check didn't catch this? > > Because in my local world I did the changes to libslirp; I wanted to > make sure qemu people were happy with the changes before proposing them > to libslirp. > > Which I've just done: > > https://gitlab.freedesktop.org/slirp/libslirp/-/merge_requests/112
I mean make check. It worked for me on my PULL request. I would have assumed that it checks slirp. Later, Juan.
