On 11/17/2011 12:04 AM, Stefan Hajnoczi wrote:
On Fri, Nov 11, 2011 at 6:47 AM, Supriya Kannery <supri...@linux.vnet.ibm.com> wrote:+ { + .name = "block_set_hostcache", + .args_type = "device:B,option:b", + .params = "device on|off", + .help = "Change setting of host pagecache", + .user_print = monitor_user_noop, + .mhandler.cmd_new = do_block_set_hostcache, + }, +STEXI +@item block_set_hostcache @var{device} @var{setting}@var{option}
Will send updated patch
+@findex block_set_hostcache +Change host pagecache setting of a block device while guest is running. +ETEXI + { .name = "eject", Index: qemu/qmp-commands.hx =================================================================== --- qemu.orig/qmp-commands.hx +++ qemu/qmp-commands.hx @@ -716,7 +716,34 @@ Example: EQMP + { + .name = "block_set_hostcache", + .args_type = "device:B,option:b", + .params = "device on|off", + .help = "Change setting of host pagecache (true|false)",It would be more consistent to use "on|off" instead of "true|false". Or eliminate it entirely by saying "Enable or disable host pagecache usage". Stefan
Followed similar way how set_link is done. Specified 'true/false' in brackets as 'on' or 'off' are not accepted as bool parameter in qmp prompt.
