On Montag, 7. Februar 2022 11:57:25 CET Dr. David Alan Gilbert wrote: > * Greg Kurz (gr...@kaod.org) wrote: > > On Mon, 7 Feb 2022 11:30:18 +0100 > > > > Philippe Mathieu-Daudé <f4...@amsat.org> wrote: > > > On 7/2/22 09:47, Greg Kurz wrote: > > > > On Sun, 6 Feb 2022 20:10:23 -0500 > > > > > > > > Will Cohen <wwco...@gmail.com> wrote: > > > >> This patch set currently places it in 9p-util only because 9p is the > > > >> only > > > >> place where this issue seems to have come up so far and we were wary > > > >> of > > > >> editing files too far afield, but I have no attachment to its > > > >> specific > > > >> location! > > > > > > > > Inline comments are preferred on qemu-devel. Please don't top post ! > > > > This complicates the review a lot. > > > > > > > > This is indeed a good candidate for osdep. This being said, unless > > > > there's > > > > some other user in the QEMU code base, it is acceptable to leave it > > > > under > > > > 9pfs. > > > > > > virtiofsd could eventually use it. > > > > Indeed but virtiofsd is for linux hosts only AFAICT and I'm not aware of > > any work to support any other host OS. > > > > Cc'ing virtio-fs people for inputs on this topic. > > Indeeed, there's a lot of Linux specific code in the virtiofsd - I know > people are interested in other platforms, but I'm not sure that's the > right starting point. > > Dave
Agreeing with Greg here: i.e. I would have placed this into osdep, but I would not insist on it either. Best regards, Christian Schoenebeck