On 2/7/22 11:36, Peter Xu wrote:
Yeah I can do. Though the latter "if (!flags)" check will also start to allow nesting of memory_global_dirty_log_start(), and it'll make this assert useless:assert(!(global_dirty_tracking & flags)); I'll probably drop it too, then. Curious: do we have any real case of nesting calls of starting dirty log? I always thought there's none, but I could miss something.
I don't think so, but I think there's no disadvantage in allowing it. Paolo