On Tue, Feb 15, 2022 at 06:41:21PM -0300, Fabiano Rosas wrote: > The goal of this series is to do some untangling of SPR registration > code in cpu_init.c and prepare for moving the CPU initialization into > separate files for each CPU family. > > The first 23 patches are all simple cleanups: > - Remove unnecessary comments/code; > - Reuse some pieces of code where it makes sense; > - Group spr_register calls; > - Remove bare spr_register calls from init_proc; > - Separate code that affects different CPU families; > > The last 4 patches move common SPR registration routines out of > cpu_init.c so that the cpu-specific code that uses them can move to > other files. > > After this series we'll have only cpu-specific SPR code in cpu_init.c, > i.e. code that can be split and moved as a unit into other > files. Common/generic SPR code will be in helper_regs.c, exposed via > spr_tcg.h.
These are some very nice cleanups, and rather overdue. You've also done a great job of splitting them up into easy to review pieces, thanks. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature