On Tue, Feb 15, 2022 at 06:41:36PM -0300, Fabiano Rosas wrote: > Signed-off-by: Fabiano Rosas <faro...@linux.ibm.com>
There's only one caller of the new function, and no commit message, so the rationale for splitting these out isn't obvious. > --- > target/ppc/cpu_init.c | 24 +++++++++++++++--------- > 1 file changed, 15 insertions(+), 9 deletions(-) > > diff --git a/target/ppc/cpu_init.c b/target/ppc/cpu_init.c > index 03aa543814..ddd27c21ae 100644 > --- a/target/ppc/cpu_init.c > +++ b/target/ppc/cpu_init.c > @@ -503,6 +503,20 @@ static void register_755_sprs(CPUPPCState *env) > 0x00000000); > } > > +static void register_755_L2_cache_sprs(CPUPPCState *env) > +{ > + /* L2 cache control */ > + spr_register(env, SPR_L2CR, "L2CR", > + SPR_NOACCESS, SPR_NOACCESS, > + &spr_read_generic, spr_access_nop, > + 0x00000000); > + > + spr_register(env, SPR_L2PMCR, "L2PMCR", > + SPR_NOACCESS, SPR_NOACCESS, > + &spr_read_generic, &spr_write_generic, > + 0x00000000); > +} > + > /* SPR common to all 7xx PowerPC implementations */ > static void register_7xx_sprs(CPUPPCState *env) > { > @@ -4549,16 +4563,8 @@ static void init_proc_755(CPUPPCState *env) > register_sdr1_sprs(env); > register_7xx_sprs(env); > register_755_sprs(env); > - /* L2 cache control */ > - spr_register(env, SPR_L2CR, "L2CR", > - SPR_NOACCESS, SPR_NOACCESS, > - &spr_read_generic, spr_access_nop, > - 0x00000000); > + register_755_L2_cache_sprs(env); > > - spr_register(env, SPR_L2PMCR, "L2PMCR", > - SPR_NOACCESS, SPR_NOACCESS, > - &spr_read_generic, &spr_write_generic, > - 0x00000000); > /* Thermal management */ > register_thrm_sprs(env); > -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature