On 11/18/2011 04:38 PM, Peter Maydell wrote: > Incidentally, another cleanup that would be nice: > there are currently two users of sysbus_init_mmio_cb2(): > hw/ppce500_pci.c and hw/sh_pci.c. I think these should be > rewritable to either use one memory region with some > subregions, or to expose multiple sysbus mmios for the > user to map appropriately. That would let us get rid of > the mmio_cb2 stuff completely. (cf commit 7d6e771 where > I did this for versatile_pci.c.)
Those cleanups are fine, but not through my tree please. Each should go through the respective maintainer, I'd like to restrict my tree to the bare minimum needed for the conversion. -- error compiling committee.c: too many arguments to function
