On 15.02.22 21:27, David Miller wrote: > tests/tcg/s390x/mie3-compl.c: [N]*K instructions > tests/tcg/s390x/mie3-mvcrl.c: MVCRL instruction > tests/tcg/s390x/mie3-sel.c: SELECT instruction >
(I know, a lot of mails from my side :) ) 1. I think we usually use the prefix in the subject "tests/tcg/s390x: " 2. Make sure the patches are checkpatch clean as good as possible: For this patch: $ rm *.patch $ git format-patch -1 $ ./scripts/checkpatch.pl *.patch WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #45: new file mode 100644 ERROR: spaces required around that ':' (ctx:VxW) #53: FILE: tests/tcg/s390x/mie3-compl.c:4: +#define F_EPI "stg %%r0, %[res] ": [res] "+m" (res) : : "r0", "r2", "r3" ^ ERROR: unnecessary whitespace before a quoted newline #57: FILE: tests/tcg/s390x/mie3-compl.c:8: + "lg %%r2, %[a] \n" \ ERROR: space prohibited before that close parenthesis ')' #61: FILE: tests/tcg/s390x/mie3-compl.c:12: + : "r2", "r3" ) ERROR: unnecessary whitespace before a quoted newline #67: FILE: tests/tcg/s390x/mie3-compl.c:18: +FbinOp(_ncrk, asm("ncrk %%r0, %%r3, %%r2 \n" F_EPI)) ERROR: unnecessary whitespace before a quoted newline #68: FILE: tests/tcg/s390x/mie3-compl.c:19: +FbinOp(_ncgrk, asm("ncgrk %%r0, %%r3, %%r2 \n" F_EPI)) ... -- Thanks, David / dhildenb