On Wed, 16 Feb 2022 at 22:45, Bernhard Beschow <shen...@gmail.com> wrote: > > Based on commit e735b55a8c11dd455e31ccd4420e6c9485191d0c: > > piix_pci: eliminate PIIX3State::pci_irq_levels > > PIIX3State::pci_irq_levels are redundant which is already tracked by > PCIBus layer. So eliminate them. > > The IRQ levels in the PCIBus layer are already preserved during > migration. By reusing them and rather than having a redundant implementation > the bug is avoided in the first place. > > Suggested-by: Peter Maydell <peter.mayd...@linaro.org> > Signed-off-by: Bernhard Beschow <shen...@gmail.com> > --- > hw/mips/gt64xxx_pci.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-)
Ah, this is definitely the best place in the series to make this fix. I didn't realize we had access to the device pointer here, I was just looking at the fact that the opaque was the irq array rather than the device pointer and didn't realize there was a global floating around with it. Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM
