On Fri, 18 Feb 2022 10:23:02 +0000 Jonathan Cameron via <qemu-devel@nongnu.org> wrote:
> Goto label is incorrect so msi cleanup would not occur if there is > an error in the ssvid initialization. > > Signed-off-by: Jonathan Cameron <jonathan.came...@huawei.com> +Cc: linux...@huawei.com Turns out you get a weird result if you miss a space in your git send-email command. Apologies to Michael for scrambling his email address as a result! > --- > Noticed whilst working on equivalent CXL upstream switch port. > > hw/pci-bridge/xio3130_upstream.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/pci-bridge/xio3130_upstream.c > b/hw/pci-bridge/xio3130_upstream.c > index 5cd3af4fbc..5ff46ef050 100644 > --- a/hw/pci-bridge/xio3130_upstream.c > +++ b/hw/pci-bridge/xio3130_upstream.c > @@ -75,7 +75,7 @@ static void xio3130_upstream_realize(PCIDevice *d, Error > **errp) > XIO3130_SSVID_SVID, XIO3130_SSVID_SSID, > errp); > if (rc < 0) { > - goto err_bridge; > + goto err_msi; > } > > rc = pcie_cap_init(d, XIO3130_EXP_OFFSET, PCI_EXP_TYPE_UPSTREAM,