On Fri, Feb 18, 2022 at 01:37:51PM +0000, Peter Maydell wrote: > On Thu, 3 Feb 2022 at 14:01, Edgar E. Iglesias <edgar.igles...@gmail.com> > wrote: > > > > From: "Edgar E. Iglesias" <edgar.igles...@xilinx.com> > > > > Add a model of the Xilinx ZynqMP CRF. At the moment this > > is mostly a stub model. > > > > Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> > > Signed-off-by: Edgar E. Iglesias <edgar.igles...@xilinx.com> > > --- > > > > +#define TYPE_XLNX_ZYNQMP_CRF "xlnx.zynqmp_crf" > > + > > +#define XILINX_CRF(obj) \ > > + OBJECT_CHECK(XlnxZynqMPCRF, (obj), TYPE_XLNX_ZYNQMP_CRF) > > We prefer the OBJECT_DECLARE_SIMPLE_TYPE rather than directly > defining a cast macro these days. (It also provides a typedef > for you, among other things.) > > Apart from that, and dropping minimum_version_id_old, > Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> >
Thanks Peter and Luc for review comments. Sorry, things have been very busy around here, I'll try to get a new version posted next week addressing all comments I've seen so far. Best regards, Edgar
