On 22/2/22 20:34, Bernhard Beschow wrote:
All isabus_dev_print() did was to print up to two IRQ numbers per
device. This is redundant if the IRQ numbers are present as QOM
properties (see e.g. the modified tests/qemu-iotests/172.out).

Now that the last devices relying on isabus_dev_print() had their IRQ
numbers QOM'ified, the contribution of this function ultimately became
redundant. Remove it.

Signed-off-by: Bernhard Beschow <shen...@gmail.com>
---
  hw/isa/isa-bus.c           | 16 ----------------
  tests/qemu-iotests/172.out | 26 --------------------------
  2 files changed, 42 deletions(-)

Also the ISA IRQ is now displayed in HMP (the human monitor):

Before:

(qemu) info qtree
       ...
          dev: mc146818rtc, id ""
            gpio-out "" 1
            base_year = 0 (0x0)
            lost_tick_policy = "discard"

After:

          dev: mc146818rtc, id ""
            gpio-out "" 1
            base_year = 0 (0x0)
            irq = 8 (0x8)
            lost_tick_policy = "discard"

Maybe worth mentioning it in the description.

Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>

Reply via email to