On Wed, 2 Mar 2022 17:45:58 +0200 Liav Albani <liav...@gmail.com> wrote:
> >>> but I feel quoting spec > >>> and including table name is a good idea actually, but pls quote verbatim: > >>> > >> I don't do that and don't ask it from others. > >> > >> The reason being that pointing where to look in spec and having > >> verbatim copy of field name is sufficient > >> for looking it up and > >> QEMU does not endup with half of spec copied in (+unintentional mistakes). > >> (As reviewer I will check if whatever written in patch actually matches > >> spec anyways) > >> > >> That's why I typically use > >> 'spec ver, verbatim field name[, chapter/table name]' > >> policy. The later optional part is usually used for pointing > >> to values description. > > > > Ok but here the field name was not listed verbatim, and table name > > is missing. It is actually 8042 and table name is Fixed ACPI Description > > Table Boot Architecture Flags. > So, in which route should I go with this? I could add a reference to the > ACPI spec, but can write and explain more if you want me to. A reference to spec is sufficient, as long as it is unambiguous and lets a reviewer easily find it within the spec
