On Fri, 4 Mar 2022 at 19:52, Richard Henderson <richard.hender...@linaro.org> wrote: > > On 3/4/22 01:52, Peter Maydell wrote: > > Is it not possible to implement this in the usual "change > > property for older versioned machines" way of adding to > > the hw_compat arrays? > > > > diff --git a/hw/core/machine.c b/hw/core/machine.c > > index d856485cb4d..dac82a709ba 100644 > > --- a/hw/core/machine.c > > +++ b/hw/core/machine.c > > @@ -37,7 +37,9 @@ > > #include "hw/virtio/virtio.h" > > #include "hw/virtio/virtio-pci.h" > > > > -GlobalProperty hw_compat_6_2[] = {}; > > +GlobalProperty hw_compat_6_2[] = { > > + { "arm-cpu-max", "lpa2", "false" }, > > +}; > > const size_t hw_compat_6_2_len = G_N_ELEMENTS(hw_compat_6_2); > > Hmm, I didn't try that, just mirrored the other examples within hw/arm/virt.c. > I guess the real type name would be TYPE_ARM_MAX_CPU, or "max-arm-cpu". > > ... > > Yes, that works. I'll send an update.
Do check it with KVM as well, to check the "CPU doesn't actually have that property" case... -- PMM