On Sonntag, 6. März 2022 07:39:49 CET Akihiko Odaki wrote:
> MacOSX.sdk/System/Library/Frameworks/CoreAudio.framework/Headers/AudioHardwa
> re.h
> says:
> > The return value is currently unused and should always be 0.
Where does it say that, about which macOS functions? There are quite a bunch
of macOS functions involved in init_out_device(), and they all have error
pathes in init_out_device(), and they still will have them after this patch.
And again, I'm missing: this as an improvement because? Is this a user
invisible improvement (e.g. removing redundant branches), or is this a user
visible improvement, i.e. does it fix a misbehaviour? In case of the latter,
which misbehaviour did you encounter?
Best regards,
Christian Schoenebeck
>
> Signed-off-by: Akihiko Odaki <akihiko.od...@gmail.com>
> ---
> audio/coreaudio.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/audio/coreaudio.c b/audio/coreaudio.c
> index 0f19d0ce01c..91445096358 100644
> --- a/audio/coreaudio.c
> +++ b/audio/coreaudio.c
> @@ -540,7 +540,6 @@ static OSStatus handle_voice_change(
> const AudioObjectPropertyAddress *in_addresses,
> void *in_client_data)
> {
> - OSStatus status;
> coreaudioVoiceOut *core = in_client_data;
>
> qemu_mutex_lock_iothread();
> @@ -549,13 +548,12 @@ static OSStatus handle_voice_change(
> fini_out_device(core);
> }
>
> - status = init_out_device(core);
> - if (!status) {
> + if (!init_out_device(core)) {
> update_device_playback_state(core);
> }
>
> qemu_mutex_unlock_iothread();
> - return status;
> + return 0;
> }
>
> static int coreaudio_init_out(HWVoiceOut *hw, struct audsettings *as,
